----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126864/#review91501 -----------------------------------------------------------
Ship it! Ship It! - David Edmundson On Jan. 23, 2016, 10:55 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126864/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2016, 10:55 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > + add warning if listen fails, just in case > > Change-Id: I27c8b166a6127fad3793024bdb950239ffc93d35 > > > Diffs > ----- > > src/ioslaves/http/http_cache_cleaner.cpp > c272c6ecc75ef07418cdfe4a17af4b0475d6ff0a > > Diff: https://git.reviewboard.kde.org/r/126864/diff/ > > > Testing > ------- > > I was getting > kio_http_cache_cleaner: '/home/dfaure/.cache/http' does not exist. > > Maybe it was only because the unittest was using ~/.qttest/cache > (QStandardPaths test mode), which is passed along to kio_http, which then > talks to kio_http_cache_cleaner without telling it where the cache is, so > they disagree on the cache. Corner case due to different paths in unit-tests, > but can't hurt to mkpath. > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
