----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126804/#review91400 -----------------------------------------------------------
Ow nice, I recall working on this during the initial Plasma5 porting and suitably neglected it after failing to get it to work nicely. Seems now we have much more reasonable Qt API to make this work nicely. (Or perhaps you're just smarter than I am. :)) Couple of comments inline, but looks already pretty good. src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp (line 251) <https://git.reviewboard.kde.org/r/126804/#comment62478> So this means that we either pass an empty image, or an outdated one? I'm not entirely following the code, but I think the image should be redrawn when the drag starts, as the data may change and we definitely want to show the currently dragged data. src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp (line 303) <https://git.reviewboard.kde.org/r/126804/#comment62475> This should be DPI-dependent src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp (line 316) <https://git.reviewboard.kde.org/r/126804/#comment62476> Q_FOREACH and const& src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp (line 321) <https://git.reviewboard.kde.org/r/126804/#comment62477> DPI-dependent, could be shared with the above - Sebastian Kügler On Jan. 18, 2016, 9 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126804/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 9 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdeclarative > > > Description > ------- > > Implement grabbing image of delegate with QQuickItem::grabToImage. > > > Diffs > ----- > > src/qmlcontrols/draganddrop/DeclarativeDragArea.h 32092ab > src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp ee78ff9 > > Diff: https://git.reviewboard.kde.org/r/126804/diff/ > > > Testing > ------- > > QQuickItem::grabToImage is async, not sure how safe is to delay the start of > drag. It seems to work without any issues though. > > > Thanks, > > David Rosca > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
