----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126818/#review91358 -----------------------------------------------------------
src/platforms/xcb/kwindowsystem_p_x11.h (line 147) <https://git.reviewboard.kde.org/r/126818/#comment62455> Should this (maybe) be static? Or rather Q_GLOBAL_STATIC? Or we'll just have one of those backends anyway? - Aleix Pol Gonzalez On Jan. 20, 2016, 12:21 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126818/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2016, 12:21 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kwindowsystem > > > Description > ------- > > appRootWindow is (relatively) expensive and won't change. > nativeEventFilter is called a lot > > This should speed things up. > > CCBUG: 356479 > > > Diffs > ----- > > src/platforms/xcb/kwindowsystem.cpp > 9d287043c24894ca3c29c439c7939b139da055e8 > src/platforms/xcb/kwindowsystem_p_x11.h > 3fa82a436d7fe12b50f7e8efd7338faf817f6579 > > Diff: https://git.reviewboard.kde.org/r/126818/diff/ > > > Testing > ------- > > Ran some apps and they seemed to still work. > Not tested any specific functionality. > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
