----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126813/#review91338 -----------------------------------------------------------
The symbol `polkit_system_bus_name_get_user_sync` doesn't exist in the Debian stable polkit libraries (it doesn't exist in the polkit-1 package sources or Debian patches either). The Debian stable package version is 0.105-8. The patch does allow polkit-qt-1 to build, but presumably it might lead to link errors if `SystemBusNameSubject::user()` is referenced. Wouldn't it be better to deal with the symbol `polkit_system_bus_name_get_user_sync` in the same manner as `polkit_authority_get_sync` and `polkit_agent_listener_register`, which if they are missing from the libraries, CMakeLists.txt sets the conditional define `POLKIT_QT_1_COMPATIBILITY_MODE`. That could also be used to conditionally compile the code referencing `polkit_system_bus_name_get_user_sync`. - David Jarvie On Jan. 19, 2016, 1:09 p.m., Alex Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126813/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2016, 1:09 p.m.) > > > Review request for KDE Frameworks. > > > Repository: polkit-qt-1 > > > Description > ------- > > Seems like the function exists, but the header declaration is missing > > > Diffs > ----- > > core/polkitqt1-subject.cpp ecb4c0e216d5bacf5dff5cf100611b941d3e8fbd > > Diff: https://git.reviewboard.kde.org/r/126813/diff/ > > > Testing > ------- > > compiles now > > > Thanks, > > Alex Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
