----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126725/#review91304 -----------------------------------------------------------
Ship it! Ship It! - David Faure On Jan. 14, 2016, 11:21 a.m., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126725/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 11:21 a.m.) > > > Review request for KDE Frameworks and Christoph Feck. > > > Repository: kwidgetsaddons > > > Description > ------- > > I was seeing a systematic crash on exitting kdenlive5, on OS X deep under the > `delete menu()` instruction in `KSelectAction::~KSelectAction`. The backtrace > suggested this might be due to a pending event (or an event due to the menu > deletion) being delivered post-mortem to an instance of a QMenu related class. > > My fix is based on 3 principles: > 1) release the "foreign" member instance (`menu()`) before releasing the own > d-ptr > 2) Remove the QMenu instance from ourselves before deleting it to have one > less potential dangling reference to it > 3) QMenu is a QObject descendent that corresponds to a UI element: on OS X it > is safer to dispose these through `deleteLater()` rather than directly. > > > Diffs > ----- > > src/kselectaction.cpp 1381099 > > Diff: https://git.reviewboard.kde.org/r/126725/diff/ > > > Testing > ------- > > On OS X 10.9.5, Qt 5.5.1 and KF5 Frameworks 5.16.0, built for installation > under /opt/local . > > It seems that points 1) and 2) above already solve the crash issue in > kdenlive on OS X, but the general principle stands so I suggest keeping 3) in > library code like this. > > > Thanks, > > René J.V. Bertin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
