> On Янв. 13, 2016, 11:30 п.п., Aleix Pol Gonzalez wrote: > > Only the foreach I don't understand, as for the rest, note that `NewStatus` > > first argument is `QString`. > > > > Use QString::fromLatin1().
What to put in kstatusnotifieritemdbus_.cpp ? - Andrey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126734/#review91034 ----------------------------------------------------------- On Янв. 13, 2016, 11:30 п.п., Andrey Cygankov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126734/ > ----------------------------------------------------------- > > (Updated Янв. 13, 2016, 11:30 п.п.) > > > Review request for KDE Frameworks and Aleix Pol Gonzalez. > > > Repository: knotifications > > > Description > ------- > > Fix Clazy warnings in KNotifications. > Fixed all but the these warnings: > /src/kstatusnotifieritemdbus_p.cpp:189:12: > [-Wclazy-qstring-uneeded-heap-allocations] > /src/kstatusnotifieritemdbus_p.cpp:204:12: > [-Wclazy-qstring-uneeded-heap-allocations] > /src/kstatusnotifieritem.cpp:109:47: > [-Wclazy-qstring-uneeded-heap-allocations] > /src/kstatusnotifieritem.cpp:532:51: > [-Wclazy-qstring-uneeded-heap-allocations] > /src/kstatusnotifieritem.cpp:974:14: [-Wclazy-foreach] > Maybe it false-positive warnings? > > > Diffs > ----- > > src/knotificationrestrictions.cpp c979a78 > src/notifybypopup.cpp e3090ba > src/notifybypopupgrowl.cpp 504ad90 > > Diff: https://git.reviewboard.kde.org/r/126734/diff/ > > > Testing > ------- > > Built without errors. > No tests available. > > > Thanks, > > Andrey Cygankov > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
