----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126723/#review90956 -----------------------------------------------------------
Patch looks good - normally I would say that the build-deps need to be bumped to request an appropriate Polkit version (0.113), but e.g. Debian backports this change to the older 0.105 release - and that seems to be quite common. So I am not sure about the best solution (bump dep upstream have it patched downstream, or just leave it the way it is and do not require a higher version number). - Matthias Klumpp On Jan. 12, 2016, 9:09 vorm., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126723/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2016, 9:09 vorm.) > > > Review request for KDE Frameworks, David Edmundson, Hrvoje Senjan, and > Matthias Klumpp. > > > Repository: polkit-qt-1 > > > Description > ------- > > This adds a new method to SystemBusNameSubject to get to the > UnixUserIdentity for the subject. > > > Diffs > ----- > > core/polkitqt1-subject.h 4c7a22bae51a501f9aed2eadac0579baea174d0d > core/polkitqt1-subject.cpp f0d69c647f00728525ee78e946a938f270ddb300 > > Diff: https://git.reviewboard.kde.org/r/126723/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
