> On Jan. 8, 2016, 1:20 a.m., Aleix Pol Gonzalez wrote: > > I did it myself because you're a GCI student, but besides compilation, you > > should have checked if tests still pass and specified so in the testing > > field. > > > > The change looks, good. Thanks! > > Andrey Cygankov wrote: > Please tell me how to run the auto-tests?
`make test` For this to work you need to pass -DBUILD_TESTING=TRUE to cmake (but if you use our recommended kdesrc-build setup, it does that already) - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126670/#review90784 ----------------------------------------------------------- On Jan. 8, 2016, 1:15 a.m., Andrey Cygankov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126670/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2016, 1:15 a.m.) > > > Review request for KDE Frameworks and Aleix Pol Gonzalez. > > > Repository: kpeople > > > Description > ------- > > Fix some Clazy warnings: > - qstring-uneeded-heap-allocations > - isempty-vs-count > - detaching-temporary > - variant-sanitizer > > > Diffs > ----- > > autotests/persondatatests.cpp 43a7c7b > autotests/personsmodeltest.cpp 1cbc3dc > examples/contactlistwidgets.cpp 56bb01c > examples/personwidget.cpp b4d73c8 > src/personmanager.cpp 5c3d3e1 > src/personpluginmanager.cpp f5396d9 > src/widgets/actions.cpp ffaf16f > src/widgets/mergedelegate.cpp 01c988d > src/widgets/persondetailsview.cpp 7e4e24f > > Diff: https://git.reviewboard.kde.org/r/126670/diff/ > > > Testing > ------- > > Compiling without errors. > > > Thanks, > > Andrey Cygankov > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
