----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126662/#review90762 -----------------------------------------------------------
src/kpackage/packageloader.cpp (line 219) <https://git.reviewboard.kde.org/r/126662/#comment62051> I would just change for Q_FOREACH. src/kpackage/packageloader.cpp (line 274) <https://git.reviewboard.kde.org/r/126662/#comment62052> I would just change for Q_FOREACH. src/kpackagetool/kpackagetool.cpp (line 351) <https://git.reviewboard.kde.org/r/126662/#comment62054> Why's this change? src/kpackagetool/kpackagetool.cpp (line 516) <https://git.reviewboard.kde.org/r/126662/#comment62053> I would just change for Q_FOREACH. - Aleix Pol Gonzalez On Jan. 7, 2016, 4:42 p.m., Mihail Ivchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126662/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 4:42 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kpackage > > > Description > ------- > > GCI task: > https://codein.withgoogle.com/dashboard/task-instances/5822614106800128/ > > > Diffs > ----- > > src/kpackagetool/kpackagetool.cpp 61a0043 > src/kpackage/private/packages_p.h 27b8ed9 > src/kpackage/packageloader.cpp 9f7dd48 > > Diff: https://git.reviewboard.kde.org/r/126662/diff/ > > > Testing > ------- > > Tests passed > > > Thanks, > > Mihail Ivchenko > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
