----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126620/ -----------------------------------------------------------
(Updated Sty 4, 2016, 9:38 po poĊudniu) Review request for KDE Frameworks and Aleix Pol Gonzalez. Changes ------- Removed change breaking Qt 5.3 compat Repository: kparts Description ------- Fixed `warning: QString* being called [-Wclazy-qstring-uneeded-heap-allocations]` by changing to `QStringLiteral`-s. In `plugin.cpp:96` I haven't fixed the warnings, becouse `QStringLiteral` would give an error. I applied my own optimisation instead. Fixed `warning: Don't call QList::first() on temporary [-Wclazy-detaching-temporary]` by changeing to `at(0)` Fixed `warning: Reserve candidate [-Wclazy-reserve-candidates]` by adding a simple `reserve` Fixed `warning: Old Style Connect [-Wclazy-old-style-connect]` I had to change all of them by hand, becouse of a bug in clazy that I will be reporting. I wasn't able to change 4 Old Style Connects. (3 in `kreadonlypart.cpp`, 1 in `readwritepart.cpp`) Fixed `warning: KParts::BrowserOpenOrSaveQuestion has dtor but not copy-ctor, copy-assignment [-Wclazy-rule-of-three]`, by adding `Q_DISABLE_COPY`, becouse `BrowserOpenOrSaveQuestionPrivate` isn't copyable Only warnings that I left are the `[-Wclazy-function-args-by-ref]` warnings, becouse they would involve modifying headers. Diffs (updated) ----- src/browserextension.cpp 4b7252c src/browseropenorsavequestion.h 85dcfa0 src/browseropenorsavequestion.cpp c1425c1 src/browserrun.cpp 4756511 src/browserrun_p.h 4742598 src/mainwindow.cpp 9b0c3c5 src/part.cpp 1657561 src/partmanager.cpp 81bf73f src/plugin.cpp 97f7d28 src/scriptableextension.cpp 27676bc Diff: https://git.reviewboard.kde.org/r/126620/diff/ Testing ------- Automated tests pass. Imported note: On my computer I'm runing versions 5.17.0 and it wasn't possible for me to upgrade easly, so I changed the CMakeFiles.txt to compile it. (of course the changed isn't included in this RR) Thanks, Artur Puzio
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
