----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126494/#review90546 -----------------------------------------------------------
Ship it! I can't see anything obviously wrong with it. (But also can't judge if it's obviously right.) Given the possible impact, I'd say go for it. - Sebastian Kügler On Dec. 23, 2015, 10:46 p.m., Ralf Habacker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126494/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2015, 10:46 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcoreaddons > > > Description > ------- > > Add cross compile support for desktoptojson. > > > Diffs > ----- > > KF5CoreAddonsConfig.cmake.in dce3a4e65599b286d8fedbaa20235f5025f509e8 > > Diff: https://git.reviewboard.kde.org/r/126494/diff/ > > > Testing > ------- > > Cross compiled package has been build at > https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win32:KF516/mingw32-kcoreaddons > > > Thanks, > > Ralf Habacker > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
