> On Dec. 29, 2015, 10:50 p.m., Kai Uwe Broulik wrote: > > src/knotification.h, line 251 > > <https://git.reviewboard.kde.org/r/126459/diff/1/?file=425181#file425181line251> > > > > This must be 0x10! > > > > 0x10 = 0b10000 (one bit set) > > > > 0x22 = 0b10110 (multiple bits) > > > > You unintentionally set a bunch of other flags with it, you probably > > didn't notice that you set the PersistentFlag as the Plasma delete > > notification sets it anyway. :) > > Kai Uwe Broulik wrote: > Err, 0x16 = 0b10110 > You probably meant 16 in decimal, which is 10 in hex. You get the idea.
Oops, well spotted! Fix pushed, thanks. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126459/#review90310 ----------------------------------------------------------- On Dec. 29, 2015, 9:07 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126459/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2015, 9:07 p.m.) > > > Review request for KDE Frameworks. > > > Repository: knotifications > > > Description > ------- > > Plasma currently groups notifications that have the same > notification title or if they are on a "blacklist" (like > media player apps that popup a notification for each song > change), but sometimes the grouping needs to be skipped. > This is for example when user removes two widgets from his > desktop and the "Undo" notification appears, these cannot > be grouped. > > This is currently handled rather by a hack in the notifications > server, so introducing this new flag should allow for a clean > and proper solution. > > > Diffs > ----- > > src/knotification.h 3a4acd5 > src/notifybypopup.cpp e824d39 > > Diff: https://git.reviewboard.kde.org/r/126459/diff/ > > > Testing > ------- > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
