----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126556/#review90275 -----------------------------------------------------------
Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 29, 2015, 6:52 a.m., Matthew Dawson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126556/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2015, 6:52 a.m.) > > > Review request for KDE Frameworks and Matthew Dawson. > > > Repository: kconfig > > > Description > ------- > > During a kconf_update run, an invalid group name may be treated as correct > even though the name failed to unescape. This leads the group name to be > a null character, which will fail. > > If the unescape failed, return that failure status instead. This should have > no impact, as the previous result would have been wrong anyways. Now a > more useful diagnostic will be returned instead. > > Update the unit tests to ensure this issue is tested in the future. > > Found in Coverity issue 258087. > > > Diffs > ----- > > autotests/test_kconfigutils.cpp 0946cf8a89135e12c1769a3ab6749434aa9691ce > src/kconf_update/kconfigutils.cpp 02b3f0a9d245fdc9d0067635e9b59bc84eefc206 > > Diff: https://git.reviewboard.kde.org/r/126556/diff/ > > > Testing > ------- > > Unit tests pass after change, new test fails without code change. > > > Thanks, > > Matthew Dawson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
