----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126505/ -----------------------------------------------------------
(Updated Dec. 27, 2015, 2:36 p.m.) Review request for KDE Frameworks and Christoph Feck. Changes ------- A mismatch is now detected as soon as the verification is not a prefix of the password. Not only this is better from the usability point of view, but now the patch is also much simpler. Repository: kwidgetsaddons Description ------- As discussed in RR 125619 and 126426, the password verification field (in a KNewPasswordWidget) should not be marked as "wrong" before the user even started typing the verification password. My revised approach is the following: * the first time, no "warning color" is displayed at all. The user types something as password and then something else as verification password. * If a match occurred (e.g. pwd = 1234 and verification = 1234), we "enable" the warning color. So if the user "breaks" the match (e.g. changing the value in one of the two fields) the warning color will be displayed. * Otherwise, if a mismatch occurred, we also enable the warning color and we show it immediately. A mismatch occurs when the password and the verification password have same length but different content (e.g. pwd = 1234 and verification = 1233). Diffs (updated) ----- autotests/knewpasswordwidgettest.h 43845128adec01aced4353c9f7986b7977829a2a autotests/knewpasswordwidgettest.cpp 297b88d5f18b9cd37f0d26d94e56f38870756f20 src/knewpasswordwidget.cpp a1b59454a2c2d7c09ac32acec52d3fffa73f77fc Diff: https://git.reviewboard.kde.org/r/126505/diff/ Testing ------- Autotests assert what described above. Gif pictures would explain the patch better than 1000 words, but I suck at creating them :( Thanks, Elvis Angelaccio
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
