----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126506/#review90085 -----------------------------------------------------------
Ship it! Ship It! - David Faure On Dec. 25, 2015, 12:12 a.m., Michael Pyne wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126506/ > ----------------------------------------------------------- > > (Updated Dec. 25, 2015, 12:12 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > Noted by Coverity (CID 1019869), and could result in a set of > partially-destructed objects. Which, in this case, would probably leak > memory in the event of multiple levels of filesystem hierarchy from the > root KDirModel, but wouldn't cause any worse problems than that. > > The 'proper' fix would be to add a virtual dtor at the base class but I > didn't want to add a vtable just for this, so I mirrored the rest of the > code and utilized the fact that item().isDir() is true for all derived > classes. > > > Diffs > ----- > > src/widgets/kdirmodel.cpp af56a06 > > Diff: https://git.reviewboard.kde.org/r/126506/diff/ > > > Testing > ------- > > Builds, kdirmodeltest passes. > > > Thanks, > > Michael Pyne > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
