----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126508/#review90078 -----------------------------------------------------------
Ship it! And more things than you'd think still use `kdesu`... - Aleix Pol Gonzalez On Dec. 25, 2015, 1:19 a.m., Michael Pyne wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126508/ > ----------------------------------------------------------- > > (Updated Dec. 25, 2015, 1:19 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kdesu > > > Description > ------- > > Don't leak fd when creating socket. > > Coverity notes (CID 1289177) that we leak the fd for our socket in > pretty much every error handling path. > > Rather than laboriously add close(fd) calls everywhere I instead added a > scope guard (and turned it off at the 'successful return' part). > > > Diffs > ----- > > src/kdesud/kdesud.cpp f991727 > > Diff: https://git.reviewboard.kde.org/r/126508/diff/ > > > Testing > ------- > > Builds but I'm not sure what even still uses kdesu in 2015... > > > Thanks, > > Michael Pyne > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
