> On Dec. 24, 2015, 10:30 a.m., Christian Ehrlicher wrote: > > src/lib/io/kurlmimedata.cpp, line 59 > > <https://git.reviewboard.kde.org/r/126392/diff/3/?file=424671#file424671line59> > > > > const? Or would this be an ABI breakage?
Yes, that can't be changed now. Not because of ABI, but source-compatibility. > On Dec. 24, 2015, 10:30 a.m., Christian Ehrlicher wrote: > > src/lib/io/kdirwatch_p.h, line 107 > > <https://git.reviewboard.kde.org/r/126392/diff/3/?file=424668#file424668line107> > > > > const That's unrelated to the change. If you want it fixed, create your RR. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/#review90049 ----------------------------------------------------------- On Dec. 24, 2015, 12:58 p.m., Andrey Cygankov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126392/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2015, 12:58 p.m.) > > > Review request for KDE Frameworks and Aleix Pol Gonzalez. > > > Repository: kcoreaddons > > > Description > ------- > > Fix some Clazy warnings: > - unneeded heap allocation with QString > - midRef() non-usage > - isEmpty() non-usage > > > Diffs > ----- > > src/lib/io/kbackup.h ead2de5 > autotests/ktexttohtmltest.cpp 81c3fc0 > src/lib/io/kprocess.cpp 1df61c0 > src/lib/io/kmessage.cpp 305318c > src/lib/io/kdirwatch.cpp 34b32b7 > src/lib/io/kdirwatch_p.h 4483961 > src/lib/io/kbackup.cpp ec8b8b2 > src/lib/io/kurlmimedata.cpp 4095ee1 > src/lib/kaboutdata.h 0dbd7a0 > src/lib/kaboutdata.cpp 5d9a55e > src/lib/randomness/krandom.cpp 2eb80d2 > src/lib/text/kmacroexpander.cpp 0d05ffd > src/lib/text/kstringhandler.cpp 826ddcb > src/lib/text/ktexttohtml.cpp d58f5c0 > src/lib/util/kshell.cpp 11892ce > > Diff: https://git.reviewboard.kde.org/r/126392/diff/ > > > Testing > ------- > > Compiling without errors > > > Thanks, > > Andrey Cygankov > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
