> On Dec. 23, 2015, 3:46 p.m., Aleix Pol Gonzalez wrote: > > Can you commit? > > Imran Tatriev wrote: > Done! ;)
Next time, add a `REVIEW: 126400` statement after the commit message to link it directly. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126400/#review89993 ----------------------------------------------------------- On Dec. 17, 2015, 4 p.m., Imran Tatriev wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126400/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 4 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kconfig > > > Description > ------- > > I've fixed some warnings, here they are: > > - Unneeded heap allocation with QString > - Detaching temporary > - Multi-arg non-usage > - isEmpty() non-usage > - midRef() non-usage > - "QVariant::toFoo() instead of QVariant::value<Foo>()" non-usage > > > Diffs > ----- > > autotests/kconfig_compiler/kconfigcompiler_test.cpp 231e3c4 > autotests/kconfig_compiler/kconfigcompiler_test_signals.cpp 9a26ca1 > src/core/kconfiggroup.cpp e09d602 > src/core/kemailsettings.cpp 59d5f6e > src/gui/kconfiggroupgui.cpp b8d3089 > src/kconf_update/kconf_update.cpp 9567c2d > src/kconf_update/kconfigutils.cpp 12b0749 > src/kconfig_compiler/kconfig_compiler.cpp 91f6005 > src/kreadconfig/kwriteconfig.cpp a852c28 > > Diff: https://git.reviewboard.kde.org/r/126400/diff/ > > > Testing > ------- > > > Thanks, > > Imran Tatriev > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
