----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126384/#review89600 -----------------------------------------------------------
Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 16, 2015, 1:43 p.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126384/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2015, 1:43 p.m.) > > > Review request for KDE Frameworks and Aleix Pol Gonzalez. > > > Repository: purpose > > > Description > ------- > > don't say it's failed as a description, just say what it's looking for. > currently it says it's failed even when it's found what it needs > > > Diffs > ----- > > src/plugins/cmake/FindQMLModule.cmake 63c3542 > > Diff: https://git.reviewboard.kde.org/r/126384/diff/ > > > Testing > ------- > > run it with and without qmlplugindump installed, it now no longer says it's > failed even when it hasn't > > > Thanks, > > Jonathan Riddell > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
