> On Dec. 14, 2015, 7:10 p.m., Sergio Martins wrote: > > src/klocalizedstring.cpp, line 389 > > <https://git.reviewboard.kde.org/r/126350/diff/1/?file=422775#file422775line389> > > > > this will break the build with MSVC, it doesn't support QStringLiteral > > with multi-line literals. > > > > (hint: > > export > > CLAZY_EXTRA_OPTIONS="qstring-uneeded-heap-allocations-msvc-compat" > > )
why QString is used for debug output in the first place? there is operator<<(const char * s) for latin1 text, which is the case (i.e. no non-latin symbols are used in the literals) using strings for debugging output is suboptimal - Nick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126350/#review89492 ----------------------------------------------------------- On Dec. 14, 2015, 6:46 p.m., Artur Puzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126350/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2015, 6:46 p.m.) > > > Review request for KDE Frameworks and Aleix Pol Gonzalez. > > > Repository: ki18n > > > Description > ------- > > Fixed `warning: KuitSetup has dtor, copy-ctor but not copy-assignment > [-Wclazy-rule-of-three]` > Fixed `warning: Reserve candidate [-Wclazy-reserve-candidates]` > Fixed `warning: Use QVariant::toFoo() instead of QVariant::value<Foo>() > [-Wclazy-variant-sanitizer]` > Fixed `warning: Use midRef() instead [-Wclazy-qstring-ref]` > Fixed `warning: Pass small and trivially-copyable type by value (const class > QChar &) [-Wclazy-foreach]` > Fixed `warning: QString::fromLatin1() being passed a literal > [-Wclazy-qstring-uneeded-heap-allocations]` > Fixed `warning: QString(const char*) being called > [-Wclazy-qstring-uneeded-heap-allocations]` > Fixed `warning: QString(QLatin1String) being called > [-Wclazy-qstring-uneeded-heap-allocations]` > > > Diffs > ----- > > src/kcatalog.cpp 7711e9b > src/klocalizedcontext.cpp 3bc42dd > src/common_helpers.cpp dad7f84 > src/klocalizedstring.cpp 69950d2 > src/ktranscript.cpp 04dda66 > src/kuitmarkup.h d110ca3 > src/kuitmarkup.cpp 02b891a > > Diff: https://git.reviewboard.kde.org/r/126350/diff/ > > > Testing > ------- > > Automated tests 1,3 and 4 passing. > Test 2 fails on my system both: after changes and before. > > > Thanks, > > Artur Puzio > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
