----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126056/#review88689 -----------------------------------------------------------
Ship it! Ship It! - Alex Merry On Nov. 22, 2015, 11:43 a.m., Heiko Becker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126056/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2015, 11:43 a.m.) > > > Review request for KDE Frameworks and Uri Herrera. > > > Repository: breeze-icons > > > Description > ------- > > It was previously hard-coded to prefix/share which is not helpful on a > multiarch layout, where the prefix might be something like /usr/${arch} > but arch independent files should still go into /usr/share. > > Also clean up unecessary cmake code. "cmake_minimum_required(VERSION 2.8)" > was already set to a higher value in the root CMakeLists.txt, same for > "set (CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")". > Furthermore I couldn't find any '*.sh' files in the repo. > > REVIEW: 126056 > > > Diffs > ----- > > icons-dark/CMakeLists.txt f039db19e1df89f62a33dc323cf0b8344d9b33fd > icons/CMakeLists.txt 6c6e3b7efb6ca1490ed52356beaf06c4e181fee0 > > Diff: https://git.reviewboard.kde.org/r/126056/diff/ > > > Testing > ------- > > Icons get installed into the desired location. > > > Thanks, > > Heiko Becker > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
