----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125619/ -----------------------------------------------------------
(Updated Nov. 19, 2015, 11:04 a.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks and Christoph Feck. Changes ------- Submitted with commit 425805a86e99e9699c53faa6ce581599582281b9 by Elvis Angelaccio to branch master. Repository: kwidgetsaddons Description ------- Follow-up of the KNewPasswordWidget review. By introducing a KNewPasswordWidget in the .ui file, we can: - remove the code that has been moved to KNewPasswordWidget - enable the KNewPasswordWidget additional features The only feature that is currently not available is the ability to remove the strength bar. Do we want to allow developers to show a KNewPasswordDialog without a strenght bar? Diffs ----- src/knewpassworddialog.h 1ac7b2151f1e88681a15ce21465449cedb871f1e src/knewpassworddialog.cpp 9b79524f03937dbd2da04ddca6bccc29825b044b src/knewpassworddialog.ui 55a1f62cf4ba6d6c87b2c47742ba3bcd531ebfe8 Diff: https://git.reviewboard.kde.org/r/125619/diff/ Testing ------- Trying to insert a password which is too short or too weak or empty, works as expected. File Attachments ---------------- knewpassworddialog1.png https://git.reviewboard.kde.org/media/uploaded/files/2015/10/13/62bf21f6-1dcf-46c3-8b1d-146500b5f629__knewpassworddialog1.png knewpassworddialog2.png https://git.reviewboard.kde.org/media/uploaded/files/2015/10/13/b2e2666f-ce19-4df3-b6ba-25c13fc370ae__knewpassworddialog2.png knewpassworddialog3.png https://git.reviewboard.kde.org/media/uploaded/files/2015/10/13/b9536088-0cc4-470b-a211-6db4ca79aa2f__knewpassworddialog3.png knewpassworddialog4.png https://git.reviewboard.kde.org/media/uploaded/files/2015/10/13/4f826716-9ed2-4ecb-8cbe-4fb50abf1086__knewpassworddialog4.png Thanks, Elvis Angelaccio
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
