> On Nov. 17, 2015, 10:05 a.m., Marco Martin wrote: > > a public symbol could even be spared (and in the process made possibleto > > use it from pure qml) by making an import instead that does the > > setContextObject() injection in its setupEngine (that would happen > > immediately after an import org.kde.i18n statement) > > > > the problem tough would be that then could be hard maintaining > > retrocompatibility in kdeclarative (tough an explicit > > QQmlEngine::importPlugin *may* work) > > Aleix Pol Gonzalez wrote: > What if the application already has a ContextObject? > > In fact, then we wouldn't be able to port KDeclarative, AFAIU: > https://git.reviewboard.kde.org/r/126088/
that's why it should probably be available also as a singleton.. - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126087/#review88465 ----------------------------------------------------------- On Nov. 18, 2015, 12:26 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126087/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2015, 12:26 p.m.) > > > Review request for KDE Frameworks, Chusslove Illich and Marco Martin. > > > Repository: ki18n > > > Description > ------- > > The only way to use `i18n*()` so far in QML is by depending on all > KDeclarative. This patch moves the necessary bits there so it can be adopted > by an application or framework just by offering the needed bits within KI18n. > This is done by offering an object with methods that map to the `i18n*()` C++ > counter-parts. > > > Diffs > ----- > > docs/programmers-guide.md 13a5f9d > src/CMakeLists.txt 818595e > src/klocalizedcontext.h PRE-CREATION > src/klocalizedcontext.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126087/diff/ > > > Testing > ------- > > Ported KDeclarative, everything still seems to work. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
