----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126086/#review88426 -----------------------------------------------------------
src/CMakeLists.txt (line 1) <https://git.reviewboard.kde.org/r/126086/#comment60602> Move it in the upper CMakeLists.txt file together with `include(ECMGenerateHeaders)`. Otherwise looks good to me. +1 - Aleix Pol Gonzalez On Nov. 16, 2015, 1:47 p.m., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126086/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2015, 1:47 p.m.) > > > Review request for KDE Software on Mac OS X and KDE Frameworks. > > > Repository: kauth > > > Description > ------- > > kauth-policy-gen should not be built as an app bundle on OS X. > This can be achieved by using `ecm_mark_nongui-executable` and apparently > there are advantages and no contra-indications to doing that on all platforms. > > > Diffs > ----- > > src/CMakeLists.txt 1b6930d > > Diff: https://git.reviewboard.kde.org/r/126086/diff/ > > > Testing > ------- > > On OS X 10.9 with Qt 5.5.1 and Frameworks 5.16.0 > > > Thanks, > > René J.V. Bertin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
