----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125976/#review88195 -----------------------------------------------------------
Ship it! Nice. Few issues with the wording in the comments, but generally looks good. src/kpackage/package.h (line 97) <https://git.reviewboard.kde.org/r/125976/#comment60482> /tmp may not be /tmp (definitely not on Windows) src/kpackage/package.h (line 98) <https://git.reviewboard.kde.org/r/125976/#comment60481> ...on the harddisk (though this should probably not say harddisk, but filesystem) src/kpackage/package.h (line 99) <https://git.reviewboard.kde.org/r/125976/#comment60483> -(from the hard disk) Nice. - Sebastian Kügler On Nov. 9, 2015, 2:40 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125976/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2015, 2:40 p.m.) > > > Review request for KDE Frameworks, Plasma and Kai Uwe Broulik. > > > Repository: kpackage > > > Description > ------- > > new job based update() function that compared to install() > if a package with the same pluginId is already installed, > removes the old one before installing the new one, if > and only if the version of the new one is more recent > > > Diffs > ----- > > autotests/plasmoidpackagetest.h f730dce > autotests/plasmoidpackagetest.cpp cccc567 > src/kpackage/CMakeLists.txt 3696f37 > src/kpackage/package.h 4ada8da > src/kpackage/package.cpp 539b21a > src/kpackage/packagestructure.h 9427b42 > src/kpackage/packagestructure.cpp 0070514 > src/kpackage/private/packagejob.cpp 0d2241b > src/kpackage/private/packagejob_p.h 267429f > src/kpackage/private/packagejobthread.cpp ca523b3 > src/kpackage/private/packagejobthread_p.h bf8a266 > src/kpackage/private/versionparser.cpp PRE-CREATION > src/kpackagetool/CMakeLists.txt 78e0fb0 > > Diff: https://git.reviewboard.kde.org/r/125976/diff/ > > > Testing > ------- > > covered by autotests > > > Thanks, > > Marco Martin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
