----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124147/#review88157 -----------------------------------------------------------
Ship it! sorry about the delay, this fell through the cracks. Don't hesitate to ping when this happens... src/ioslaves/http/kcookiejar/kcookieserver.cpp (line 68) <https://git.reviewboard.kde.org/r/124147/#comment60466> make that QDir(kcookiejarDirName), like the other return statement. src/ioslaves/http/kcookiejar/kcookieserver.cpp (line 73) <https://git.reviewboard.kde.org/r/124147/#comment60467> I suppose this should be Q_NULLPTR instead. - David Faure On July 23, 2015, 5:19 a.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124147/ > ----------------------------------------------------------- > > (Updated July 23, 2015, 5:19 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > Prevents a cold start bug when the data dir is not created. Also, by > storing the file name as a member of the KCookieServer class we avoid > calculating it every time cookies are saved. > > > Diffs > ----- > > src/ioslaves/http/kcookiejar/kcookieserver.h > f61c7d0e4da58b805565632cf3dd484445c21275 > src/ioslaves/http/kcookiejar/kcookieserver.cpp > ac585a0b04637c485647564d18a89a75d6c11d97 > > Diff: https://git.reviewboard.kde.org/r/124147/diff/ > > > Testing > ------- > > Restarted kded5 with no file named kcookiejar inside ~/.local/share and with > a regular file named kcookiejar in that location. > > In my setup, the message box is not showing properly but I am not sure if > this is somethign that happens only on my computer or if this is something > wrong with the code, can somebody confirm? > > > Thanks, > > David Narváez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
