----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125815/#review88105 -----------------------------------------------------------
src/util/urlhandler.cpp (line 49) <https://git.reviewboard.kde.org/r/125815/#comment60442> there is no point in using QStringLiteral there as a deep copy is done anyways. using QLatin1String would take almost the same time, except that the .so binary would be smaller. instead for QStandardPaths::findExecutable it does make sense to use QStringLiteral - Nick Shaforostoff On Nov. 6, 2015, 4:48 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125815/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2015, 4:48 p.m.) > > > Review request for KDE Frameworks, Christoph Cullmann and Luigi Toscano. > > > Repository: kguiaddons > > > Description > ------- > > Tries to reach out to docs.kde.org when khelpcenter is not available. > > > Diffs > ----- > > src/util/urlhandler.cpp 5b46be2 > > Diff: https://git.reviewboard.kde.org/r/125815/diff/ > > > Testing > ------- > > I tried it with a couple of applications. For the main documentation just > works. > > Needs figuring out for more complex cases, I'm unsure if applications are > opening the documentation in specific pages. In fact, I couldn't find the > documentation for docs.kde.org url scheme, and I just made up the `path` > part, although it seems to work. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
