> On Nov. 6, 2015, 12:25 p.m., Milian Wolff wrote: > > I'd remove the code, instead of just commenting it out if it's really not > > needed. > > > > Also, minor nitpick: QList<T*> is pretty much equivalent to QVector<T*>, > > you won't see any big difference, performance or memory wise. That said, > > I'm all for using QVector everywhere by default. It's certainly not worse > > than QList ;-) > > > > Thanks! > > > > Oh and maybe wait for a review of David before pushing this. I have no clue > > about the code itself. The patch looks fine from my POV though.
above should read: ...`QList<T*>` is pretty much equivalent to `QVector<T*>`... - Milian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125971/#review88094 ----------------------------------------------------------- On Nov. 5, 2015, 11:55 p.m., Nick Shaforostoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125971/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2015, 11:55 p.m.) > > > Review request for KDE Frameworks and Laurent Montel. > > > Repository: karchive > > > Description > ------- > > i couldn't find the place where the pointers contained in the member arrays > are deleted so i have added their releasing. for this i have used qDeleteAll > (you can search for qDeleteAll in the diff) > > also i have reordered members of FileInfo to reduce its 'sizeof' > also using qvector for storing pointers is as fast as using qlist (or even > faster) and needs less memory > also i have switched qvector acces from operator[] to .at() because it is > const (doesn't call detach() method internally) > also i have disabled the code that was filling 'method' string because it was > not used anywhere after > > > Diffs > ----- > > src/k7zip.cpp 321620a > > Diff: https://git.reviewboard.kde.org/r/125971/diff/ > > > Testing > ------- > > compiles fine > > > Thanks, > > Nick Shaforostoff > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
