----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125965/#review88099 -----------------------------------------------------------
src/declarative/holidayregionsmodel.cpp (line 81) <https://git.reviewboard.kde.org/r/125965/#comment60440> i suggest enclosing strings into QByteArrayLiteral. see http://woboq.com/blog/qstringliteral.html for explanation and https://gitlab.com/pteam/pteam-qtbase/commit/05663e29d047851adb9a1ef440fb78b38ff3cc9b for the case when QBAL are not suitable - Nick Shaforostoff On Nov. 5, 2015, 7:57 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125965/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2015, 7:57 p.m.) > > > Review request for KDE Frameworks and John Layt. > > > Repository: kholidays > > > Description > ------- > > For now it contains just the model of holiday regions > which will be used in the Plasma calendar events > configuration. > > > Diffs > ----- > > CMakeLists.txt e8b7970 > src/CMakeLists.txt c067b6c > src/declarative/CMakeLists.txt PRE-CREATION > src/declarative/holidayregionsmodel.h PRE-CREATION > src/declarative/holidayregionsmodel.cpp PRE-CREATION > src/declarative/kholidaysdeclarativeplugin.h PRE-CREATION > src/declarative/kholidaysdeclarativeplugin.cpp PRE-CREATION > src/declarative/qmldir PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125965/diff/ > > > Testing > ------- > > Applet configuration contains proper list of available > holiday regions. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
