----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125936/#review88081 -----------------------------------------------------------
src/kcms/kio/cache.cpp (line 91) <https://git.reviewboard.kde.org/r/125936/#comment60434> Isn't this done by the call to updateRunningIOSlaves just below, which sends the DBus signal "reparseSlaveConfiguration" to all processes with a KIO scheduler, which, in SchedulerPrivate::slotReparseSlaveConfiguration, calls KProtocolManager::reparseConfiguration? Please check why this doesn't happen in your testcase. I can think of a few possibilities: - there's no KIO scheduler in this process - you need this reparsed before going back to the event loop (but from your description it doesn't seem so) - there's a bug in the emitting or the handling of that dbus signal (which is why I'm asking, if there is, we might as well find it and fix it). - David Faure On Nov. 4, 2015, 6:28 a.m., Andreas Cord-Landwehr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125936/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2015, 6:28 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > Fixes missing update of Settings->Cache KCM that happens if opening > KCM, changing values (e.g., "No Cache"), closing Cache KCM, opening Cache > KCM again. > > Reason is that storing and loading of UI values is performed > asymmetrically in two different KSharedConfig objects. Now force second > KSharedData to sync once settings are saved. > > > Diffs > ----- > > src/kcms/kio/cache.cpp 8f2f4e8 > > Diff: https://git.reviewboard.kde.org/r/125936/diff/ > > > Testing > ------- > > manual testing > > > Thanks, > > Andreas Cord-Landwehr > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
