----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125969/#review88068 -----------------------------------------------------------
Generally makes sense to me, other than my first note below: src/kdeinit/kinit.cpp (line 370) <https://git.reviewboard.kde.org/r/125969/#comment60428> Why call fromRawData with an explicit strlen()? QByteArray(displayEnvVarName()) will have the same effect. src/kdeinit/kinit.cpp (lines 1076 - 1077) <https://git.reviewboard.kde.org/r/125969/#comment60429> This whole thing is unpleasantly C-ish, and a QByteArray or QVector<char> would have been altogether nicer, but that would be a much bigger refactoring of the code. - Alex Merry On Nov. 5, 2015, 10:16 p.m., Nick Shaforostoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125969/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2015, 10:16 p.m.) > > > Review request for KDE Frameworks and Alex Merry. > > > Repository: kinit > > > Description > ------- > > this patch fixes two coverity issues ranked 'outstanding': > https://scan5.coverity.com/reports.htm#v39099/p10103/fileInstanceId=82663767&defectInstanceId=24554334&mergedDefectId=258481 > https://scan5.coverity.com/reports.htm#v39099/p10103/fileInstanceId=82663767&defectInstanceId=24557588&mergedDefectId=258474 > > and also does small string-related optimization by eliminating redundant > mallocs done by QByteArray ctor > > > Diffs > ----- > > src/kdeinit/kinit.cpp 9e775b6 > > Diff: https://git.reviewboard.kde.org/r/125969/diff/ > > > Testing > ------- > > compiles fine > > > Thanks, > > Nick Shaforostoff > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
