----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125941/#review87980 -----------------------------------------------------------
autotests/kcompressiondevicetest.cpp (line 29) <https://git.reviewboard.kde.org/r/125941/#comment60359> Can't KArchive do that already? autotests/kcompressiondevicetest.cpp (line 69) <https://git.reviewboard.kde.org/r/125941/#comment60358> Use QTemporaryDir. autotests/kcompressiondevicetest.cpp (line 79) <https://git.reviewboard.kde.org/r/125941/#comment60357> You should compare to the file size, otherwise this all will have to be changed every time these files are modified. Good first step! - Aleix Pol Gonzalez On Nov. 4, 2015, 3:08 a.m., Romário Rios wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125941/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2015, 3:08 a.m.) > > > Review request for KDE Frameworks and Aleix Pol Gonzalez. > > > Repository: karchive > > > Description > ------- > > I recently noticed that using KTar with KCompressionDevice and QNetworkReply > did not work, so I'm adding some tests to confirm that > > > Diffs > ----- > > autotests/CMakeLists.txt 1b2e819 > autotests/kcompressiondevicetest.h PRE-CREATION > autotests/kcompressiondevicetest.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125941/diff/ > > > Testing > ------- > > The tests run and show that KCompressionDevice isn't working as expected > > > Thanks, > > Romário Rios > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
