-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125938/#review87970
-----------------------------------------------------------



src/kdeui/kpixmapcache.cpp (line 132)
<https://git.reviewboard.kde.org/r/125938/#comment60353>

    Why time_t here, and quint32 further down? If anything, I'd expect it to be 
the other way around - this is the one that's important to be fixed.


- Alex Merry


On Nov. 3, 2015, 8:53 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125938/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 8:53 p.m.)
> 
> 
> Review request for KDE Frameworks and Michael Pyne.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> -------
> 
> Need to use POD types.
> 
> 
> Diffs
> -----
> 
>   src/kdeui/kpixmapcache.cpp c16384d 
> 
> Diff: https://git.reviewboard.kde.org/r/125938/diff/
> 
> 
> Testing
> -------
> 
> kigo doesn't crash on startup anymore.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to