----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125928/#review87903 -----------------------------------------------------------
+1 otherwise :) src/filewidgets/knewfilemenu.cpp (lines 581 - 582) <https://git.reviewboard.kde.org/r/125928/#comment60305> You can hand over the srcFile directly to storedPut, storedPut has an overload which takes a QIODevice - Emmanuel Pescosta On Nov. 3, 2015, 9:24 a.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125928/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2015, 9:24 a.m.) > > > Review request for KDE Frameworks, Christoph Cullmann, Frank Reininghaus, Rex > Dieter, and Harald Sitter. > > > Bugs: 353642 > https://bugs.kde.org/show_bug.cgi?id=353642 > > > Repository: kio > > > Description > ------- > > This solves the conflict with kde-baseapps 15.08.x, and simplifies deployment > on Win/Mac. > > BUG: 353642 > Change-Id: Id4f9e364ceeea6b1b93910aa100ff22ce3fd76a7 > > > Diffs > ----- > > src/new_file_templates/templates.qrc PRE-CREATION > autotests/knewfilemenutest.cpp 968e16e9e8c5d0680c1e6e00af1403f3f5d9976f > src/CMakeLists.txt 27b0f2b0e86a0087d343226e8db056109b3cd5ab > src/filewidgets/CMakeLists.txt 6ec254971055d1d1ecf5cf7a6d4637b82a52c27d > src/filewidgets/knewfilemenu.cpp 577206dfa9c89c4db4750f1880547bfb9b6214e7 > src/new_file_templates/CMakeLists.txt > 0684b1871b35757ebe59c71cff01104bc388bb0f > > Diff: https://git.reviewboard.kde.org/r/125928/diff/ > > > Testing > ------- > > Unittest (./knewfilemenutest) > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
