----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125830/#review87644 -----------------------------------------------------------
Ship it! src/core/kprotocolinfofactory.cpp (line 79) <https://git.reviewboard.kde.org/r/125830/#comment60149> You can ensure that by adding Q_ASSERT(!m_mutex.tryLock()); (this is a trick I learned from webkit code) - David Faure On Oct. 28, 2015, 7:34 a.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125830/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2015, 7:34 a.m.) > > > Review request for KDE Frameworks, Alex Richardson and David Faure. > > > Repository: kio > > > Description > ------- > > Extends the protocol factory and co. to allow reading of protocol data from > embedded json. > Allows to deploy io slaves without anything else than the io slave itself in > librarypath kf5/kio. > > I changed to factory to ALWAYS fill its cache for any request, as now the > determination which protocols are around is more expensive than just some > directory traversal. > > If this preview is ok, I will do that for all other shipped slaves and update > this request. > > > Diffs > ----- > > src/core/kprotocolinfo.cpp 8a02f7a > src/core/kprotocolinfo_p.h c3dea6b > src/core/kprotocolinfofactory.cpp 29ba8f4 > src/core/kprotocolinfofactory_p.h aa79fc5 > src/ioslaves/http/http.cpp 1727d41 > src/ioslaves/http/http.json PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125830/diff/ > > > Testing > ------- > > http slave still seems to be found and work. > > > Thanks, > > Christoph Cullmann > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
