----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125852/#review87620 -----------------------------------------------------------
Thanks for the patch. I'll see to remove the boost requirement for the library first. It should not be used anywhere overly important, and people are complaining that it makes windows builds hard. - Ivan Čukić On Oct. 28, 2015, 9:48 p.m., Heiko Becker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125852/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2015, 9:48 p.m.) > > > Review request for KDE Frameworks and Ivan Čukić. > > > Bugs: 354521 > http://bugs.kde.org/show_bug.cgi?id=354521 > > > Repository: kactivities > > > Description > ------- > > This "fixes" the build with said cmake param when boost isn't available. > The boost dependency was introduced with > 9274281f68b9fc387848a4b49b36934b6b216b3c. > > BUG:354521 > > > Diffs > ----- > > src/CMakeLists.txt 8a31b209ddc12577f969f3935443169cac2caeb2 > > Diff: https://git.reviewboard.kde.org/r/125852/diff/ > > > Testing > ------- > > Builds with KACTIVITIES_LIBRARY_ONLY=TRUE and FALSE. > > Not sure if this is an acceptable way to fix the issue, or if the option > should be made to work without boost (or the option should possibly get > removed). > > > Thanks, > > Heiko Becker > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
