----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125806/#review87415 -----------------------------------------------------------
Ship it! src/kmultitabbar.cpp (line 601) <https://git.reviewboard.kde.org/r/125806/#comment60007> Add empty line after #endif - Christoph Feck On Oct. 26, 2015, 9:35 a.m., Boudewijn Rempt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125806/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2015, 9:35 a.m.) > > > Review request for KDE Frameworks and Christoph Feck. > > > Repository: kwidgetsaddons > > > Description > ------- > > With no-deprecated set, clang refuses to build kmultitabbar: > > /Users/boudewijnrempt/kf5/b/ext_frameworks/ext_kwidgetsaddons-prefix/src/ext_kwidgetsaddons/src/kmultitabbar.cpp:564:19: > error: out-of-line definition of 'appendButton' does not match any > declaration in 'KMultiTabBar' > int KMultiTabBar::appendButton(const QPixmap &pic, int id, QMenu *popup, > const QString &x) > ^~~~~~~~~~~~ > /Users/boudewijnrempt/kf5/b/ext_frameworks/ext_kwidgetsaddons-prefix/src/ext_kwidgetsaddons/src/kmultitabbar.cpp:593:19: > error: out-of-line definition of 'appendTab' does not match any > declaration in 'KMultiTabBar' > int KMultiTabBar::appendTab(const QPixmap &pic, int id, const QString &text) > ^~~~~~~~~ > > > Diffs > ----- > > src/kmultitabbar.cpp 2327748 > > Diff: https://git.reviewboard.kde.org/r/125806/diff/ > > > Testing > ------- > > > Thanks, > > Boudewijn Rempt > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
