----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125778/#review87371 -----------------------------------------------------------
So every app (packaged this way) will need a copy of the .protocol files and the kioslave executable... I much preferred the solution we talked about previously, where .protocol files would be embedded (as JSON) into the kio_<protocol> slave plugin. This at least simplified the deployment question to: how to ship and locate these plugins. And it's the Qt5 way :) Wouldn't that make it simpler to package other apps like what you're doing? - David Faure On Oct. 24, 2015, 7:06 p.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125778/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2015, 7:06 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > Allow .protocol files to be bundled with applications. > Search in app local paths first. > Side effect: protocols() result is now sorted by name and allProtocols won't > create duplicated cache entries if .protocol files are duplicated > > kioslave helper is search locally, too. > > forkSlaves check was missing in holdSlave to avoid segfault without dbus. > > > Diffs > ----- > > src/core/kprotocolinfofactory.cpp 29ba8f4 > src/core/slave.cpp 9ce0d78 > > Diff: https://git.reviewboard.kde.org/r/125778/diff/ > > > Testing > ------- > > .protocol files are now found if bundled with the application > kwrite http://www.kde.org works on mac now. > > > Thanks, > > Christoph Cullmann > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
