-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125760/
-----------------------------------------------------------

(Updated Oct. 23, 2015, 5:28 p.m.)


Review request for KDE Frameworks, Christoph Feck and Boudewijn Rempt.


Changes
-------

Added test, ok that way?


Repository: kiconthemes


Description
-------

Allow icon themes to be embedded in applications and prefer the embedded ones, 
if e.g. Krita or Kate ships an embedded theme, that shall be found and used.
Qt does already do so, by searching in :/icons.


Diffs (updated)
-----

  autotests/CMakeLists.txt 707f39b 
  autotests/kiconloader_resourcethemetest.cpp PRE-CREATION 
  autotests/resources.qrc 5385977 
  src/kicontheme.cpp d0ab4b9 

Diff: https://git.reviewboard.kde.org/r/125760/diff/


Testing
-------

Themes still work, if you have the right theme in :/icons it is found, in 
contrast to before this patch.
Still a problem, that I need to takle in a different patch: How to enforce the 
use of some theme, Qt is able to do so via setThemeName, KIconLoader and Co. 
ignore that.


Thanks,

Christoph Cullmann

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to