----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125750/ -----------------------------------------------------------
Review request for KDE Frameworks and Sebastian Kügler. Repository: kcoreaddons Description ------- I know this could be done so much better and there's a comment saying it's transitional (heh), but this happens to be called a ton of times on every plasma boot through [1]. Actually, why is it transitional? Are we supposed to move from metadata.desktop to metadata.json? Or is it because we should all be using `kpackagetool5 --generate-index`? [1] KPluginMetaData::loadFromDesktopFile(QString const&, QStringList const&) Diffs ----- src/lib/plugin/desktopfileparser.cpp 7a4556a Diff: https://git.reviewboard.kde.org/r/125750/diff/ Testing ------- Tests pass, plasma still boots. Thanks, Aleix Pol Gonzalez
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
