----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125736/ -----------------------------------------------------------
(Updated Oct. 21, 2015, 5:25 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Changes ------- Add kdeframeworks group Repository: kwindowsystem Description ------- Adds a Skip Window Close Animation effect to KWindowEffects, with an implementation for X11. Binary compatibility with older plugins is **not** preserved. I welcome comments on how exactly to do this - creating a new base class (KWindowEffectsPrivate2 based on KWindowEffectsPrivate and basing the plugins off that sounds kind of complicated). Maybe we can just drop internal ABI compatibility and update kwayland-integration to implement the new method too? Diffs ----- autotests/kwindoweffectstest.cpp 0e83bdc src/kwindoweffects.h bf0ea1e src/kwindoweffects.cpp 0c6600f src/kwindoweffects_dummy.cpp 65924ae src/kwindoweffects_dummy_p.h 2beabdd src/kwindoweffects_extensions.h PRE-CREATION src/platforms/xcb/atoms_p.h b5a6e7e src/platforms/xcb/kwindoweffects.cpp c8da6d2 src/platforms/xcb/kwindoweffects_x11.h c240ddf Diff: https://git.reviewboard.kde.org/r/125736/diff/ Testing ------- * make test succeeds with the new plugin installed * make test succeeds on all tests in the kwindoweffects test except the skipCloseAnimation unit with the old plugin installed. skipCloseAnimation segfaults. Thanks, Boudhayan Gupta
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
