----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125705/#review87113 -----------------------------------------------------------
src/declarativeimports/calendar/calendar.cpp (line 195) <https://git.reviewboard.kde.org/r/125705/#comment59864> This only checks LANG, meanwhile, LC_ALL and LC_MESSAGES, and maybe even LANGUAGE should also be considered. But I guess using the first item from QLocale().uiLanguages() would just work. - Xuetian Weng On Oct. 19, 2015, 4:13 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125705/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 4:13 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Bugs: 353715 > http://bugs.kde.org/show_bug.cgi?id=353715 > > > Repository: plasma-framework > > > Description > ------- > > Simple QDate::longMonthName won't do the job as it > will return the month name using LC_DATE locale which is used > for date formatting etc. So for example, in en_US locale > and cs_CZ LC_DATE, it would return Czech month names while > it should return English ones. So here we force the LANG > locale and take the month name from that. > > > Diffs > ----- > > src/declarativeimports/calendar/calendar.cpp 67a08e5 > > Diff: https://git.reviewboard.kde.org/r/125705/diff/ > > > Testing > ------- > > LC_DATE=cs_CZ > LANG=en_US > > Month names in calendar applet are now english. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
