----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125681/#review87107 -----------------------------------------------------------
Ship it! Looks reasonable to me, so I'd implement as long as it works in your testing. - Michael Pyne On Oct. 18, 2015, 8:58 p.m., Robby Stephenson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125681/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2015, 8:58 p.m.) > > > Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. > > > Repository: khtml > > > Description > ------- > > Avoid setting printSettings as its own parent. It should properly be > owned by the print dialog, which seems to have been the intent in KDE4. > > > Diffs > ----- > > src/khtmlview.cpp d9bbc38b1677a3faf3be46ccc3a211c8d7289e45 > > Diff: https://git.reviewboard.kde.org/r/125681/diff/ > > > Testing > ------- > > Tellico's printing (which uses KHTMLPart) no longer hangs, but works properly. > > > Thanks, > > Robby Stephenson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
