----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125537/#review86407 -----------------------------------------------------------
+1. I hit this issue today and this patch fixes it. - Luca Beltrame On Ott. 6, 2015, 4:18 a.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125537/ > ----------------------------------------------------------- > > (Updated Ott. 6, 2015, 4:18 a.m.) > > > Review request for KDE Frameworks, Albert Astals Cid and David Faure. > > > Repository: kservice > > > Description > ------- > > In 0e4d7247e27f82a9b79b19dbceb35b603baceb76, a new feature saving directory > mtime in ksycoca db is introduced. > > In the related code, TimestampChecker() will check the mtime recursively, but > the building process will only read the top level directories' mtime, which > causes ksycoca db being recreated again and again. > > I hit this because my ~/.config/menus/applications-merged mtime newer than > ~/.config/menus. And plasmashell is running with 100% since it's creating > ksycoca db repeatedly. > > This patch change the building db procedure to use the same logic as in > TimestampChecker(), so building and checking are consistent now. > > > Diffs > ----- > > autotests/ksycocatest.cpp 67f0700 > src/sycoca/kbuildsycoca.cpp 00aaac3 > > Diff: https://git.reviewboard.kde.org/r/125537/diff/ > > > Testing > ------- > > Now a sub directory with larger timestamp than parent will not cause ksycoca > data being recreated again and again. > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
