-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125497/
-----------------------------------------------------------
(Updated Oct. 4, 2015, 6:42 p.m.)
Review request for KDE Frameworks, Albert Astals Cid and Bhushan Shah.
Changes
-------
Reworked to avoid trying to utime() on system dirs, which failed due to no
permissions.
Summary (updated)
-----------------
KSycoca: store mtime for every source dir, to detect changes.
Bugs: 353036
https://bugs.kde.org/show_bug.cgi?id=353036
Repository: kservice
Description (updated)
-------
The old solution was to compare the mtime of the source dirs with
a stored timestamp of "just before listing them". However this assumes
that time always moves forward, and some people have a phone that also acts
as a time machine (a limited one, with a single possible "destination",
01/01/1970).
Well, this new solution should also avoid problems with DST making time
go back 1h once a year; or problems when changing timezones (although we
could also just use UTC everywhere for these issues).
BUG: 353036
REVIEW: 125497
Diffs (updated)
-----
autotests/ksycocatest.cpp c2fe0db2b07d41ff3f66485093b76de6981a18ba
src/sycoca/kbuildsycoca.cpp 924c55724ffeabace492b37ee3f1658a1efcee39
src/sycoca/kbuildsycoca_p.h b3a86ecc4f611219132af2ec10a8f052e27c2d4b
src/sycoca/ksycoca.cpp cc721eaf4ae42d65dccaf71eeb21211696be130c
src/sycoca/ksycoca_p.h 314aaa91d9a07896cb3cef13bdb849d5c7e359ea
Diff: https://git.reviewboard.kde.org/r/125497/diff/
Testing
-------
unit test (failed before patch, works with it).
Thanks,
David Faure
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
