> On Oct. 3, 2015, 8:40 p.m., David Edmundson wrote: > > src/kcrash.cpp, line 686 > > <https://git.reviewboard.kde.org/r/125503/diff/2/?file=409495#file409495line686> > > > > I don't think you need the -1 here. > > David Faure wrote: > I don't find the manpage for getcwd very precise on that topic, so better > safe than sorry?
Sure. Having a cwd 1999 characters long seems like quite an edge case anyway. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125503/#review86313 ----------------------------------------------------------- On Oct. 3, 2015, 9:03 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125503/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2015, 9:03 p.m.) > > > Review request for KDE Frameworks. > > > Bugs: 337760 > https://bugs.kde.org/show_bug.cgi?id=337760 > > > Repository: kcrash > > > Description > ------- > > This was the reason why the unittest failed locally (with kdeinit available) > while it worked in CI (without kdeinit). The cwd was wrong so the restarted > program was adding a line to $HOME/kcrashtest_log instead of the one here. > > BUG: 337760 > REVIEW: 125503 > > > Diffs > ----- > > src/kcrash.cpp 451267740778d927484f6bbc465918fb4e7510d5 > > Diff: https://git.reviewboard.kde.org/r/125503/diff/ > > > Testing > ------- > > autotest now passes for me > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
