----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125417/#review86000 -----------------------------------------------------------
Ship it! Ship It! - Martin Klapetek On Sept. 27, 2015, 1:29 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125417/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2015, 1:29 a.m.) > > > Review request for KDE Frameworks. > > > Repository: knotifyconfig > > > Description > ------- > > Because knotifyconfigelement has a cache, we end up calling writeEntry; > sync() ; writeEntry() ; sync() ..which sounds expensive > > This change makes that we only sync after all the writeEntry. > > > Diffs > ----- > > src/knotifyconfigelement.cpp 93fade5b2b02ea9acfb8f11dee5879aca6c0d807 > src/knotifyeventlist.cpp dd6b6e9d5557fde0b46d980e4078921dd978f13f > > Diff: https://git.reviewboard.kde.org/r/125417/diff/ > > > Testing > ------- > > Still works. > Nothing else called NotifyConfigElement::save and it's private API. > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
