-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124983/
-----------------------------------------------------------
(Updated Sept. 22, 2015, 4:37 nachm.)
Review request for KDE Frameworks and David Faure.
Changes
-------
Thanks for the comments, David, Luigi and Albert!
I've removed all devices, as suggested by David (we can actually also remove
the "Link to Device" menu from KNewFileMenu then, but I'll do that in a second
patch once the present change is in master).
If there are any further suggestions for improvement, please let me know, such
that they can be included when I push this to master after the next KF5 release.
Bugs: 349654
https://bugs.kde.org/show_bug.cgi?id=349654
Repository: kio
Description
-------
Currently, the standard entries of KNewFileMenu are in lib/konq in the
kde-baseapps repository, which has no released KF5 version. Therefore, the menu
is empty now for most users. Those who build their KDE software with
kdesrc-build, whose standard KF5 config includes kde-baseapps, might now have
noticed the issue yet.
This patch simply moves the relevant files to kio. Some questions that might be
worth discussing:
* Is kio considered the correct place for this, or should the files be in
kio-extras?
* Are all the menu entries still relevant, or should some be removed or
modified?
* Is it OK to move the desktop files including translations, or will this
confuse the i18n infrastructure that our brave translators use?
Diffs (updated)
-----
src/CMakeLists.txt a1d644d
src/new_file_templates/CMakeLists.txt PRE-CREATION
src/new_file_templates/Directory.desktop PRE-CREATION
src/new_file_templates/HTMLFile.desktop PRE-CREATION
src/new_file_templates/HTMLFile.html PRE-CREATION
src/new_file_templates/Program.desktop PRE-CREATION
src/new_file_templates/TextFile.desktop PRE-CREATION
src/new_file_templates/TextFile.txt PRE-CREATION
src/new_file_templates/URL.desktop PRE-CREATION
src/new_file_templates/linkPath.desktop PRE-CREATION
src/new_file_templates/linkProgram.desktop PRE-CREATION
src/new_file_templates/linkURL.desktop PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/124983/diff/
Testing
-------
I disabled the build of kde-baseapps locally. The "Create New..." menu was
empty then, but it is populated again with this patch.
Thanks,
Frank Reininghaus
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
