> On Sept. 22, 2015, 8:31 a.m., John Layt wrote: > > Will have a proper look when I get home tonight, what was the so number > > when released as part of kdepimlibs4? Was it 4 or 5? If 4 then we can stay > > at 5 as KHolidays has never been officially released for KF5? Or will we > > get this issue with every PIM library that was in the unofficial release? > > (And there were more abi changes than just the removal of the widget).
It has had an official release with this library name and version as part of apps15.08, albeit not as part of the frameworks releases :) So compatibility is broken, but since kde applications libraries have no source or binary compat promise we can take the easy way out and bump. There's also some additional info here: https://git.reviewboard.kde.org/r/125285/ - Harald ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125343/#review85736 ----------------------------------------------------------- On Sept. 22, 2015, 8:02 a.m., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125343/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2015, 8:02 a.m.) > > > Review request for KDE Frameworks, Daniel Vrátil and John Layt. > > > Repository: kholidays > > > Description > ------- > > since Applications/15.08 KHolidays::HolidayRegionSelector was removed > constituting an incompatible change. > > > Diffs > ----- > > CMakeLists.txt ebd4b8981a658665a42140250b6eb3d92662e607 > > Diff: https://git.reviewboard.kde.org/r/125343/diff/ > > > Testing > ------- > > > Thanks, > > Harald Sitter > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
