> On Sept. 21, 2015, 12:54 nachm., Aleix Pol Gonzalez wrote: > > cmake/FindPerlModules.cmake, line 2 > > <https://git.reviewboard.kde.org/r/125332/diff/1/?file=404914#file404914line2> > > > > How is that new file related?
The change is based on the current version of kdoctools which makes sure that perl is able to encode uris. > On Sept. 21, 2015, 12:54 nachm., Aleix Pol Gonzalez wrote: > > cmake/uriencode.cmake, line 2 > > <https://git.reviewboard.kde.org/r/125332/diff/1/?file=404915#file404915line2> > > > > should be kdelibs4support_encode_uri I'll fix that one. > On Sept. 21, 2015, 12:54 nachm., Aleix Pol Gonzalez wrote: > > src/CMakeLists.txt, line 645 > > <https://git.reviewboard.kde.org/r/125332/diff/1/?file=404916#file404916line645> > > > > That doesn't seem to make a lot of sense... This is needed as the cmake module path isn't set yet in the install step and FindPerlModules.cmake needs to be found. - Patrick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125332/#review85715 ----------------------------------------------------------- On Sept. 21, 2015, 12:41 nachm., Patrick von Reth wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125332/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2015, 12:41 nachm.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs4support > > > Description > ------- > > Use the more advanced version of uriencode.cmake from kdoctools which > supports Windows. > > > Diffs > ----- > > cmake/FindPerlModules.cmake PRE-CREATION > cmake/uriencode.cmake fde06d3ccf14212122bbee583b44158a2411fbcf > src/CMakeLists.txt 14cc57413b827286ba1d29ccf31e308b05c52413 > > Diff: https://git.reviewboard.kde.org/r/125332/diff/ > > > Testing > ------- > > Windows > > > Thanks, > > Patrick von Reth > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
